By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 2530 - Build issue: Git tdelibs FTBFS
Summary: Build issue: Git tdelibs FTBFS
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: tdelibs (show other bugs)
Version: R14.0.1 [Trinity]
Hardware: Other Linux
: P5 blocker
Assignee: Slávek Banko
URL:
Depends on:
Blocks: R14.1.0
  Show dependency tree / graph
 
Reported: 2015-09-19 13:45 CDT by Darrell
Modified: 2016-10-02 03:08 CDT (History)
5 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
Proposed patch to fix build failure (561 bytes, patch)
2015-09-19 13:45 CDT, Darrell 		Details | Diff
tdebase build log (1016.86 KB, text/x-log)
2015-09-24 19:51 CDT, Darrell 		Details
Fix FTBFS due to missing KSSL_HAVE_SSL definition (431 bytes, patch)
2015-09-24 21:05 CDT, Slávek Banko 		Details | Diff
Fix FTBFS due to missing KSSL_HAVE_SSL definition (1) (1.68 KB, patch)
2015-10-11 13:27 CDT, Slávek Banko 		Details | Diff
tdepowersave: fix FTBFS due to conflict in Success identifie (302 bytes, patch)
2015-10-21 14:50 CDT, Slávek Banko 		Details | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darrell 2015-09-19 13:45:53 CDT 
Created attachment 2570 [details]
Proposed patch to fix build failure

Latest git, updated today. Slackware 14.1. I added the following to the build script:

  -DWITH_PCSC=OFF \
  -DWITH_PKCS=OFF \
  -DWITH_CRYPTSETUP=OFF \
  -DWITH_LOGINDPOWER=OFF \

The build fails with the following:

/dev/shm/tdelibs/tdecore/tdehw/tdestoragedevice.cpp:191:27: error: 'crypt_memory_lock' was not declared in this scope

Proposed patch attached.

Yet tdelibs still fails to build with errors such as the following:

/dev/shm/tdelibs/tdecore/tdehw/tdecryptographiccarddevice.cpp:790:2: error: 'EVP_PKEY' was not declared in this scope
/dev/shm/tdelibs/tdecore/tdehw/tdecryptographiccarddevice.cpp:790:12: error: 'x509_pubkey' was not declared in this scope
/dev/shm/tdelibs/tdecore/tdehw/tdecryptographiccarddevice.cpp:791:2: error: 'RSA' was not declared in this scope
/dev/shm/tdelibs/tdecore/tdehw/tdecryptographiccarddevice.cpp:791:7: error: 'rsa_pubkey' was not declared in this scope
/dev/shm/tdelibs/tdecore/tdehw/tdecryptographiccarddevice.cpp:792:43: error: 'X509_get_pubkey' was not declared in this scope

Seems tdelibs has not been tested with the above cmake build options set to OFF.
Comment 1 Timothy Pearson 2015-09-19 18:45:27 CDT 
(In reply to Darrell from comment #0)
> Seems tdelibs has not been tested with the above cmake build options set to
> OFF.

This is a true statement.  I am working on stabilizing the system with the options on before worrying too much about fixing builds with them off.
Comment 2 Timothy Pearson 2015-09-19 19:03:01 CDT 
This should be fixed in GIT hash d4b7e6e (tdelibs).  Please test and let me know if you still experience problems.

Thanks!
Comment 3 Darrell 2015-09-20 10:09:12 CDT 
tdelibs now builds but tdebase FTBFS:

/opt/trinity/include/tdestoragedevice.h:160:2: error: expected identifier before numeric constant
/opt/trinity/include/tdestoragedevice.h:160:2: error: expected '}' before numeric constant
/opt/trinity/include/tdestoragedevice.h:160:2: error: expected unqualified-id before numeric constant
/opt/trinity/include/tdestoragedevice.h:167:1: error: expected declaration before '}' token
Comment 4 Timothy Pearson 2015-09-20 16:58:49 CDT 
(In reply to Darrell from comment #3)
> tdelibs now builds but tdebase FTBFS:
> 
> /opt/trinity/include/tdestoragedevice.h:160:2: error: expected identifier
> before numeric constant
> /opt/trinity/include/tdestoragedevice.h:160:2: error: expected '}' before
> numeric constant
> /opt/trinity/include/tdestoragedevice.h:160:2: error: expected
> unqualified-id before numeric constant
> /opt/trinity/include/tdestoragedevice.h:167:1: error: expected declaration
> before '}' token

This particular failure affected tdebase whether or not the cryptsetup/pkcs options were enabled.  Fixed in GIT hash c73eb5f (tdebase).
Comment 5 Darrell 2015-09-23 11:11:37 CDT 
tdebase FTBFS:

/dev/shm/tdebase/kcontrol/hwmanager/devicepropsdlg.cpp:980: undefined reference to `TDECryptographicCardDevice::createNewSecretRSAKeyFromCertificate(TQMemArray<char>&, TQMemArray<char>&, x509_st*)'
Comment 6 Timothy Pearson 2015-09-23 11:33:55 CDT 
(In reply to Darrell from comment #5)
> tdebase FTBFS:
> 
> /dev/shm/tdebase/kcontrol/hwmanager/devicepropsdlg.cpp:980: undefined
> reference to
> `TDECryptographicCardDevice::
> createNewSecretRSAKeyFromCertificate(TQMemArray<char>&, TQMemArray<char>&,
> x509_st*)'

This looks like a mismatch between your installed tdelibs and source tdebase version.  Can you verify that you have the latest tdelibs installed?

Thanks!
Comment 7 Darrell 2015-09-23 11:45:43 CDT 
I did a git pull and rebuild of tdelibs before building tdebase.
Comment 8 Darrell 2015-09-23 11:58:24 CDT 
Also did a full repo sync and rebuilt all core packages. Same error for several days.
Comment 9 Darrell 2015-09-24 19:51:08 CDT 
Created attachment 2571 [details]
tdebase build log
Comment 10 Slávek Banko 2015-09-24 21:05:16 CDT 
Created attachment 2572 [details]
Fix FTBFS due to missing KSSL_HAVE_SSL definition

I found a potential problem. When building tdelibs KSSL_HAVE_SSL is defined in config.h. But while using tdecryptographiccarddevice.h outside the building tdelibs value is not determined. Therefore, it may be vary and affect API.

Please, try attached patch for tdelibs.
Comment 11 Darrell 2015-09-24 23:22:14 CDT 
/dev/shm/tdelibs/tdecore/tdehw/tdecryptographiccarddevice.h:22:28: fatal error: ksslconfig.h: No such file or directory
Comment 12 Darrell 2015-10-08 14:55:25 CDT 
The previous error message is caused by a missing ksslconfig.h. That header file is compiled when building tdelibs and is not a static file. The file is not being compiled on my system. The proposed patch in attachment 2572 [details] requires ksslconfig.h, which has not yet been compiled at this stage of building tdelibs.
Comment 13 Slávek Banko 2015-10-08 18:17:49 CDT 
(In reply to Darrell from comment #12)
> The previous error message is caused by a missing ksslconfig.h. That header
> file is compiled when building tdelibs and is not a static file. The file is
> not being compiled on my system. The proposed patch in attachment 2572 [details]
> [details] requires ksslconfig.h, which has not yet been compiled at this
> stage of building tdelibs.

Yes, thank you for reminding me. In recent days I have had too little time to devote himself to this problem. I'll prepare a new patch as soon as I can find enough time.
Comment 14 Slávek Banko 2015-10-11 13:27:43 CDT 
Created attachment 2576 [details]
Fix FTBFS due to missing KSSL_HAVE_SSL definition (1)

Patch updated.
Please, try again.
Comment 15 Darrell 2015-10-11 22:09:33 CDT 
Patch in attachment 2576 [details] seems to resolve the problem.
Comment 16 Slávek Banko 2015-10-12 17:43:18 CDT 
(In reply to Darrell from comment #15)
> Patch in attachment 2576 [details] seems to resolve the problem.

Completely both - tdelibs and also tdebase?
Comment 17 Darrell 2015-10-12 17:58:57 CDT 
>Completely both - tdelibs and also tdebase?
Yes.

tdepowersave fails to build with messages similar to those in comment3.

kdbus-notification fails to build too:

daemon.moc.cpp:48:15: error: 'NotificationContainer' has not been declared
daemon.moc.cpp:60:34: error: 'TDEPassivePopupStackContainer' has not been declared

I haven't filed bug reports.
Comment 18 Slávek Banko 2015-10-21 14:50:27 CDT 
Created attachment 2583 [details]
tdepowersave: fix FTBFS due to conflict in Success identifie

Please, try attached patch for tdepowersave.

I fear that the conflict identifier 'Success' can occur even in other applications. Probably it wanted a better deal.
Comment 19 Darrell 2015-10-21 18:06:32 CDT 
>Please, try attached patch for tdepowersave.
Patch works, no build failure with tdepowersave.
Comment 20 Michele Calgaro 2016-03-28 08:06:29 CDT 
So can we close this bug? Or is there something else left to do?
Comment 21 Michele Calgaro 2016-10-01 09:42:45 CDT 
tdepowersave patch was pushed to git in commit 7eac381 (R14.1) and commit 530c292 (R14.0). This resolves the bug.
Comment 22 Slávek Banko 2016-10-01 10:03:34 CDT 
(In reply to Michele Calgaro from comment #21)
> tdepowersave patch was pushed to git in commit 7eac381 (R14.1) and commit
> 530c292 (R14.0). This resolves the bug.

For clarity - FTBFS occurred after integrating crypto devices to tdehwlib. These are not part of r14.0.x branch => patch for tdepowersave in r14.0.x branch was not needed :) However, there is no reason to revert it.
Comment 23 Michele Calgaro 2016-10-01 22:51:48 CDT 
ah ok, I thought you had just forgot to push to R14.0. My bad ;-)
Comment 24 Slávek Banko 2016-10-02 03:08:32 CDT 
Because the problem is not in relation with r14.0.x branch, there is no reason to put a bug to the list for bug 2575. Instead, should be in list for bug 2247.