By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 2687 - Some icons not displayed in systray,
Summary: Some icons not displayed in systray,
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: tdebase (show other bugs)
Version: R14.0.0 [Trinity]
Hardware: Other Linux
: P5 normal
Assignee: Michele Calgaro
URL:
Depends on:
Blocks: R14.0.4 R14.0.5
  Show dependency tree / graph
 
Reported: 2016-09-08 03:01 CDT by Q4OS Team
Modified: 2018-05-22 10:43 CDT (History)
4 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
missing icon in systray (6.04 KB, image/png)
2016-09-08 03:03 CDT, Q4OS Team 		Details
patch (1.93 KB, application/octet_stream)
2016-09-28 08:09 CDT, Michele Calgaro 		Details
patch (1) (1.46 KB, patch)
2016-09-28 08:49 CDT, Slávek Banko 		Details | Diff
Systray icon rendering (447.72 KB, application/octet-stream)
2016-11-11 06:27 CST, Q4OS Team 		Details
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Q4OS Team 2016-09-08 03:01:05 CDT 
Some of icons are not shown in the system tray. Probably, it relates only to gtk3 applications icons.

Exact steps to reproduce:
- Fresh TDE stable (14.0.3) installation on Debian Jessie.
- Install Network manager applet: 'apt-get install network-manager-gnome'
- Reboot.
- There is an empty space instead of 'nm-applet' icon in systray.
- Screenshot attached.
Comment 1 Q4OS Team 2016-09-08 03:03:13 CDT 
Created attachment 2686 [details]
missing icon in systray
Comment 2 Michele Calgaro 2016-09-09 09:31:47 CDT 
Yes, I can confirm this bug because I saw it with other non-TDE applications as well from time to time.
There was also a similar bug for missing icons on the main menu, again only for non-TDE apps.
If you edit the menu and assign an icon to the application, then save and restart TDE, does the icon shows up?
Thanks.
Comment 3 Q4OS Team 2016-09-09 14:51:22 CDT 
The Network manager 'nm-applet' has no shortcut in the start menu.
If I directly edit '/usr/share/applications/nm-applet.desktop' and assign some TDE icon, for ex. 'clock', it will show icon in systray after reboot. If I assign another icon, it will show empty space.

If I refresh systray with the command:
dcop kicker SystemTrayApplet iconSizeChanged
proper icon immediately appears in the systray.
Comment 4 Slávek Banko 2016-09-27 09:40:53 CDT 
Thank you! Thanks to your hint, I found an old KDE commit in SVN (before the fork Trinity), where is the core of the problem - method getIconSize:

https://websvn.kde.org/branches/trinity/3.5.13_frozen/kdebase/kicker/applets/systemtray/systemtrayapplet.cpp?r1=848618&r2=854109

There is hope that this long-term bug would be corrected soon!
Stay tuned :)
Comment 5 Michele Calgaro 2016-09-28 08:09:43 CDT 
Created attachment 2710 [details]
patch

Slavek, Q4OS team, 
please try attached patch and let me know if it is now ok.

I could not reproduce the problem exactly, but noticed that using another application the icon initially appeared smaller when first added to systray. After calling iconSizeChange through DCOP the icon was resized.
The current patch executes the same "resizing" code when an icon is first added to systray. Now the icon of the same application is immidiately displayed with the same size that it would have had after calling the DCOP method.
Comment 6 Slávek Banko 2016-09-28 08:49:59 CDT 
Created attachment 2711 [details]
patch (1)

The same method of solution - without changes in the method iconSizeChanged.
Tested - icon is fine, as expected.
Comment 7 Slávek Banko 2016-09-28 12:16:15 CDT 
Fixed in GIT hash 6bd9497d (master) and 89aa5220 (r14.0.x).
Comment 8 Q4OS Team 2016-11-11 06:27:25 CST 
Created attachment 2740 [details]
Systray icon rendering
Comment 9 Q4OS Team 2016-11-11 06:27:49 CST 
Unfortunately, the bug still persists, although the fix improved things a bit. The bug is still reproducible exactly the same way as before:
- Fresh TDE stable (14.0.4) installation on Debian Jessie.
- Install Network manager applet: 'apt-get install network-manager-gnome'
- Reboot.
- There is an empty space instead of 'nm-applet' icon in the system tray.

I have realized, that the icon size and placing is (very probably) correct, the problem seems to be bad icon rendering only. I have attached a short screencast, that shows the problem in a clear way.

Maybe it's about a new bug, so should I create new report or it would be better to reopen this one ?
Comment 10 Michele Calgaro 2016-11-13 03:28:17 CST 
Thanks for the feedback Q4OS team.
I have reopened the bug and added to R14.0.5 bug list
Comment 11 Slávek Banko 2016-11-13 03:49:32 CST 
Out of curiosity: nm-applet was precisely the application on that I've successfully tested the bug fix. The difference is only in the fact that I've tested it on Wheezy.
Comment 12 Michele Calgaro 2018-05-06 16:17:25 CDT 
@Q4OS team
Can you check if the problem still persist on the latest R14.0.5 preliminary build?
I just tried to reproduce the bug in buster/R14.1-dev and the network manager icon displayed ok. I tried different panel sizes as well, no problems.
Comment 13 Q4OS Team 2018-05-22 01:48:12 CDT 
Looks well now, as I am not able to reproduce this bug on the latest R14.0.5 preliminary build. Debian stable Stretch, TDE R14.0.5 preliminary.
Comment 14 Michele Calgaro 2018-05-22 10:43:23 CDT 
Ok, since we can't seem to reproduce the bug anymore and things seem ok, I am closing the bug for the time being.
Should you run into the same issue again, please reopen the bug.
Thanks for your report and testing.