2833 – Port of Breeze window decoration for TDE

By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

Bug 2833 - Port of Breeze window decoration for TDE

Summary: Port of Breeze window decoration for TDE

Status:	RESOLVED FIXED

Alias:	None

Product:	TDE
Classification:	Unclassified
Component:	tdeartwork (show other bugs)
Version:	R14.1.x [Trinity]
Hardware:	All Linux

Importance:	P5 enhancement
Assignee:	Timothy Pearson

URL:

Depends on:
Blocks:	R14.1.0
	Show dependency tree / graph

Reported:	2017-09-15 11:33 CDT by Alex Couture
Modified:	2019-04-04 09:11 CDT (History)
CC List:	4 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
Theme (101.50 KB, application/zip) 2017-09-15 11:33 CDT, Alex Couture	Details
Screenshot (822.74 KB, image/png) 2017-09-15 11:35 CDT, Alex Couture	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alex Couture 2017-09-15 11:33:48 CDT

Created attachment 2820 [details]
Theme

Hi,


I made a port of "Plasma 5 Breeze" window border for TDE. It works with the IceWM window decoration theme engine.


To try it, uncompress the attached archive in this folder:

/home/(your user name)/.trinity/share/apps/twin/icewm-themes/

or, for system-wide use, install in:
/opt/trinity/share/apps/twin/icewm-themes/


Untick the "Use theme title text colors" options, and set your window title font to "Noto Sans 10"

*** A little bug is present in the icewm window decoration theme engine: It does not always obey reliably to changes in window title text font and color. This is why I say to untick the option for font ***

Have a great day!

-Alexandre

Comment 1 Alex Couture 2017-09-15 11:35:27 CDT

Created attachment 2821 [details]
Screenshot

I attached a screenshot to see how it looks like

Comment 2 Michele Calgaro 2018-04-23 21:58:25 CDT

Looks very good, thanks!.
Moved to block bug 2247 and not 2696, since this is raised against R14.1 series

Comment 3 Michele Calgaro 2018-08-13 20:23:13 CDT

For reference infio.

In Control Center, you will see it in the window decoration category after choosing IceWM theme engine.

Comment 4 Alex Couture 2018-08-14 09:22:40 CDT

For reference info 2:

Theme icewm is from tdeartwork twin-styles package.

This theme engine is required for my theme to work.
So, if it is to be released with  R14.1.0, it wold be good
to make sure that the required package is installed automatically with TDE.

Moreover, in the package description of twin-styles, the icewm keyword should be added to make it easier to find in my favorite package manager; Synaptic

Have a great day!
-Alexandre

Comment 5 Michele Calgaro 2019-03-21 09:31:52 CDT

Finally getting ready....
https://mirror.git.trinitydesktop.org/gitea/TDE/tdeartwork/pulls/6

Thanks Alex for the original code and Greg for the integration part.

Comment 6 Alex Couture 2019-03-21 15:24:58 CDT

Thank you and have a great day!

Comment 7 gregory guy 2019-03-22 06:49:03 CDT

Hi Alexandre (didn't know you were still around),

Can you check the PR I've made to integrate your port because I have basically no ideas how your themes work (beyond the few instructions here to put everything in ${prefix}/share/apps/twin/icewm-themes/)?

https://mirror.git.trinitydesktop.org/gitea/TDE/tdeartwork/commit/c385529033126dbb480c5914220a2bec531af9c7

I've removed the file "folder16x16.xpm.old" from the icons folder and renamed "workspacebuttonactive.xpm_" into "workspacebuttonactive_.xpm" from the taskbar_top folder.
Is It fine?

I also like to invite you to contribute to TDE through the Gitea working place.
https://mirror.git.trinitydesktop.org/gitea/explore/users

Gitea is an easy to grasp collaborative tool, you wouldn't have any trouble making your way in as I did and this will leverage (ease) the integration of your contributions since you know better.

@+

Comment 8 Alex Couture 2019-03-22 10:01:50 CDT

Hi,

Humm, I don't have any way to test it for the moment, but if you try it and it works just fine, with no glitches, it is that it is okay. I wasn't aware of any changes to make to filenames to improve it.

I don't have much time to invest in TDE, but I'll still answer my messages :)

Thank you!
-Alexandre

Comment 9 gregory guy 2019-04-02 08:03:03 CDT

Alexandre,

I'm sorry to bother you again but Michele and I believe that the folders icons, taskbar, taskbar_air and taskbar_top aren't necessary for the Brise theme per-se. 

Are we right on this, can you confirm?

Even if you don't run TDE anymore and that theme of yours, you most likely remember the usefulness of those icons and folders, right?
 
Because if those folders are actually for your own settings, we'd like to take them out the commit, hence out of the Brise theme.

@+

Comment 10 Alex Couture 2019-04-02 11:37:08 CDT

Hi,

This theme engine is made to be able to run IceWM's window manager themes. Of course, in IceWM, you have files not only for the window decoration, but for menus and taskbar. When you use it Under TDE, only window decoration part is used.

But since the theme zip files weight 101.50kb, I frankly don't see the point of removing files in it. Especially since TDE takes quite often more disk space than Plasma 5...

-Alexandre

Comment 11 Michele Calgaro 2019-04-04 09:11:50 CDT

The window decoriation part has been merged into the main code.
Thanks to all people involved in this bug.