By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 2840 - SIGSEGV in konversation: removeNickFromServer deferences pointer before checking if not null
Summary: SIGSEGV in konversation: removeNickFromServer deferences pointer before check...
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: tdenetwork (show other bugs)
Version: R14.0.x [Trinity]
Hardware: amd64 Linux
: P5 critical
Assignee: Slávek Banko
URL:
Depends on:
Blocks: R14.0.5
  Show dependency tree / graph
 
Reported: 2017-09-22 03:41 CDT by Vilem Marsik
Modified: 2017-11-23 17:01 CST (History)
3 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
Patch for the SIGSEGV (749 bytes, patch)
2017-09-22 03:41 CDT, Vilem Marsik 		Details | Diff
Patch for the SIGSEGV (1) (619 bytes, patch)
2017-10-14 07:42 CDT, Slávek Banko 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vilem Marsik 2017-09-22 03:41:48 CDT 
Created attachment 2823 [details]
Patch for the SIGSEGV

konversation-14.0.4 on Fedora 26 is crashing in about 1 minute after logging in, on this sequence in server.cpp around line 2330:

bool wasOnline = nickInfo->getPrintedOnline();
if (nickInfo && wasOnline) ...

The pointer nickInfo is deferenced, before testing if not null.

Attached patch seems to have solved the problem.
Comment 1 Slávek Banko 2017-10-14 07:42:29 CDT 
Created attachment 2824 [details]
Patch for the SIGSEGV (1)

It seems that the variable wasOnline is nowhere else used in the code, so it can be completely removed - the patch is simplified.

Are you willing to provide a real email address with which I could list you as a patch author?
Comment 2 Slávek Banko 2017-11-17 04:48:59 CST 
Fixed in GIT hash 3a934bd3 (master) and d6504c60 (r14.0.x).
Thank you for bug report and patch!
Comment 3 Vilem Marsik 2017-11-23 17:01:59 CST 
Thanks for including the patch.

(In reply to Slávek Banko from comment #1)
> Are you willing to provide a real email address with which I could list you
> as a patch author?

Not really, I guess none is going to ask me any details about that.