By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 2883 - tdepim/libkpgp the GPG part needs update to gpg2
Summary: tdepim/libkpgp the GPG part needs update to gpg2
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: tdepim (show other bugs)
Version: R14.0.x [Trinity]
Hardware: Other Linux
: P5 normal
Assignee: Timothy Pearson
URL:
Depends on:
Blocks: R14.0.5
  Show dependency tree / graph
 
Reported: 2018-03-16 02:35 CDT by deloptes
Modified: 2018-05-05 12:34 CDT (History)
3 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
error (decryption failed) (39.92 KB, image/jpeg)
2018-03-16 02:35 CDT, deloptes 		Details
signed mail when knode does not display properly (6.84 KB, message/news)
2018-04-05 14:55 CDT, deloptes 		Details
signed mail when knode displays properly (5.30 KB, message/news)
2018-04-05 14:56 CDT, deloptes 		Details
signature key exctraction patch (1.07 KB, patch)
2018-04-05 16:15 CDT, deloptes 		Details | Diff
signature key exctraction patch (1.31 KB, patch)
2018-04-06 10:07 CDT, deloptes 		Details | Diff
signature key exctraction patch (2.08 KB, patch)
2018-04-07 15:54 CDT, deloptes 		Details | Diff
signature key exctraction patch (2.33 KB, patch)
2018-05-02 15:50 CDT, deloptes 		Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description deloptes 2018-03-16 02:35:38 CDT 
Created attachment 2829 [details]
error (decryption failed)

When trying to open signature in knode, I get an error (decryption failed).
I just wonder why it does not use gpgme the same as kmail.
Comment 1 deloptes 2018-04-05 14:53:18 CDT 
Luckily I could find one such message that is displayed exactly the way it is displayed also in kmail. So it looks like it depends on the way the message is structured.

The one that works is 
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
[blah blah]
-----END PGP SIGNATURE-----

The one that doesn't is 

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--gnknW2V3bf2fYIKGJhjNQYlTCuNkECDjz
Content-Type: multipart/mixed; boundary="rwgnE5jUACrJdnaOnspBSDfTe9mt7oV7O";
 protected-headers="v1"

[blah blah]

-----END PGP SIGNATURE-----

--gnknW2V3bf2fYIKGJhjNQYlTCuNkECDjz--
Comment 2 deloptes 2018-04-05 14:55:38 CDT 
Created attachment 2830 [details]
signed mail when knode does not display properly

The signature is displayed as attachment and trying opening it causes gpg to fail
Comment 3 deloptes 2018-04-05 14:56:42 CDT 
Created attachment 2831 [details]
signed mail when knode displays properly

this is one mail where it is properly displayed
Comment 4 deloptes 2018-04-05 16:15:42 CDT 
Created attachment 2832 [details]
signature key exctraction patch

old style signature
Example: Signature made Sun 06 May 2001 03:49:27 PM CEST using DSA key ID 12345678

the patch will handle new style signature
Example: Signature made Thu 05 Apr 2018 10:02:50 PM CEST
               using DSA key A0CF1DC09533E5E87F54DB40F1EEB8CD9FB16A50
Comment 5 deloptes 2018-04-05 18:02:34 CDT 
The other problem seems to be related to  ftp://ftp.rfc-editor.org/in-notes/rfc3156.txt
Comment 6 deloptes 2018-04-06 10:07:17 CDT 
Created attachment 2833 [details]
signature key exctraction patch

previous patch extended to handle variable key size

//    gpg: Signature made Thu 05 Apr 2018 10:02:50 PM CEST
//    gpg:                using DSA key A0CF1DC09533E5E87F54DB40F1EEB8CD9FB16A50

//		gpg: Signature made Mon 02 Apr 2018 03:15:08 PM CEST
//		gpg:                using DSA key 05C82CF57AD1DA46
Comment 7 deloptes 2018-04-07 15:54:11 CDT 
Created attachment 2834 [details]
signature key exctraction patch

extends the previous patch with a fix to properly display the user name in the sign/decrypt header. It prevents utf8 double encoding.

this was the last open item on knode I had for now
Comment 8 Slávek Banko 2018-05-02 15:30:52 CDT 
(In reply to deloptes from comment #7)
> Created attachment 2834 [details]
> signature key exctraction patch
> 
> extends the previous patch with a fix to properly display the user name in
> the sign/decrypt header. It prevents utf8 double encoding.
> 
> this was the last open item on knode I had for now

Please, you can test whether the use of TQstring::fromLocal8Bit() will be correct instead of the currently used TQString::fromUtf8()? When "error" is the output from the gpg call, potentially it could be in another encoding => fromLocal8Bit() should be the appropriate choice.

Thank you.
Comment 9 deloptes 2018-05-02 15:50:13 CDT 
Created attachment 2842 [details]
signature key exctraction patch

Hi,
yes it works with TQString::fromLocal8Bit().
I was not sure about this, although I thought it might be more appropriate.
thanks for looking into it
Comment 10 Slávek Banko 2018-05-05 12:34:25 CDT 
Fixed in GIT hash f09192b2 (master) and 724a547c (r14.0.x).
Thank you for your good work!