By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 2891 - admin/cvs.sh patch for automake 1.16.x
Summary: admin/cvs.sh patch for automake 1.16.x
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: other (any) (show other bugs)
Version: R14.1.x [Trinity]
Hardware: All Linux
: P5 normal
Assignee: Timothy Pearson
URL:
Depends on:
Blocks: R14.0.5
  Show dependency treegraph
 
Reported: 2018-05-04 09:34 CDT by Ray Vine
Modified: 2018-05-07 19:18 CDT (History)
4 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ray Vine 2018-05-04 09:34:42 CDT
Error:
*** YOU'RE USING automake (GNU automake) 1.16.1.
*** TDE requires automake 1.6.1 or newer

Required output:
*** automake (GNU automake) 1.16.1 found.

Patch:
--- admin/cvs.sh
+++ admin/cvs.sh
@@ -59 +59 @@
-  automake*1.6.* | automake*1.7* | automake*1.8* | automake*1.9* | automake*1.10* | automake*1.11* | automake*1.12* | automake*1.13* | automake*1.14* | automake*1.15* )
+  automake*1.6.[1-9] | automake*1.[7-9].* | automake*1.1[0-6].* )
Comment 1 Slávek Banko 2018-05-06 03:42:31 CDT
Thank you for your patch.

It looks good, but there is one mistake - when writing automake*1.[7-9].* | automake*1.1[0-6].* (with the ending dot) major versions of automake will be reported as unsupported - for example 1.15, while 1.15.1 will be accepted.

On the other hand, the current way without a ending dot adds support for versions that do not yet exist - for example 1.70. And this is probably not an intention.

The question, then, is whether to ignore this second effect and use simple way without a ending dot:

automake*1.6.[1-9] | automake*1.[7-9]* | automake*1.1[0-6]* )

Or whether to be accurate and use:

automake*1.6.[1-9] | automake*1.[7-9] | automake*1.[7-9].* | automake*1.1[0-6] | automake*1.1[0-6].* )

What is your opinion?
Comment 2 Ray Vine 2018-05-06 10:09:35 CDT
That was sloppy of me.
I just assumed major version releases would be x.x.0.
automake*1.6.[1-9] isn't necessary.

The existing test therefore looks good so my vote is for:

automake*1.6.* | automake*1.[7-9]* | automake*1.1[0-6]* )
Comment 3 Michele Calgaro 2018-05-06 14:41:00 CDT
Option 1)
Why not simply add 
| automake*1.16*
as per original code? Doesn't look particularly nice, but should provide the required functionality.

Option 2)
As Ray suggested, use
automake*1.6.* | automake*1.[7-9]* | automake*1.1[0-6]*
The problem with non existing versions of automake (like 1.70) is not really a problem. The original code would already match that (automake*1.7*)

Option 3)
automake*1.6.* | automake*1.[7-9]* | automake*1.1[0-9]*
Keep up happy until automake 1.19 and does not require updating the admin modules multiple times only for that. I think there is no much added risk here.

My preference is 3 - 2 - 1.
Comment 4 Slávek Banko 2018-05-07 19:18:56 CDT
Pushed to GIT in hash 065b9015 (master), a1cd2ba6 (r14.0.x) and 968b99af (v3.5.13-sru).
Thank you for your original patch and good idea.