By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 2948 - Build issue: smartcard auth fails rpmlint check on opensuse Leap 15.0
Summary: Build issue: smartcard auth fails rpmlint check on opensuse Leap 15.0
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: non-core programs (show other bugs)
Version: R14.0.x [Trinity]
Hardware: Other Linux
: P5 normal
Assignee: Francois Andriot
URL:
Depends on:
Blocks: R14.0.5
  Show dependency treegraph
 
Reported: 2018-07-15 14:23 CDT by Francois Andriot
Modified: 2018-07-18 04:55 CDT (History)
3 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:


Attachments
smartcardauth: fix missing return value (494 bytes, patch)
2018-07-15 14:24 CDT, Francois Andriot
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Francois Andriot 2018-07-15 14:23:12 CDT
It fails because "no return in non-void function".
Comment 1 Francois Andriot 2018-07-15 14:24:30 CDT
Created attachment 2882 [details]
smartcardauth: fix missing return value

Attached patch allows rpmlint to pass without error.
Comment 2 Michele Calgaro 2018-07-18 04:32:21 CDT
Francois,
in the current R14.0.x branch, at lines 228-229 there are the following statements:

usleep(100000);	// [FIXME] Here I assume that the entire file will be written (after it was created) within 100us.  This may not be correct in all cases!
return TQString("3F00_%1").arg(file);

So I see a return statement there. 
Why are you seeing a different code (no return)?
Comment 3 Michele Calgaro 2018-07-18 04:34:24 CDT
Sorry, ignore my previous comment. I got mixed up with parenthesis :-(
Comment 4 Michele Calgaro 2018-07-18 04:54:46 CDT
Pushed to R14.0.x in commit c7f43fb. Thanks.