By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 2984 - Prevent to try inplace edit with perl for stream editiing
Summary: Prevent to try inplace edit with perl for stream editiing
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: other (any) (show other bugs)
Version: R14.1.x [Trinity]
Hardware: Other All
: P5 normal
Assignee: Slávek Banko
URL:
Depends on:
Blocks: R14.0.6
  Show dependency tree / graph
 
Reported: 2018-11-04 01:51 CST by OBATA Akio
Modified: 2018-12-09 09:06 CST (History)
3 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
remove unwanted -i option for perl (960 bytes, patch)
2018-11-04 01:51 CST, OBATA Akio 		Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description OBATA Akio 2018-11-04 01:51:11 CST 
Created attachment 2904 [details]
remove unwanted -i option for perl

In admin/am_edit "-i" option for perl is used for stream editing, only for just one case.
It should be fixed same as other usage in the script.
Comment 1 Michele Calgaro 2018-11-07 05:09:26 CST 
Hi Mr. Obata-san,
thanks for the patches on this bug and also 2985 and 2986.
Would you be able to create PR for the same 3 bugs in our TGW? It would simplify things for:
1) testing
2) discussing together if required
3) signing off of the commit so that we can push with you as author of the patches.

TGW
https://mirror.git.trinitydesktop.org/gitea/

TGW guide
https://wiki.trinitydesktop.org/TDE_Gitea_Workspace
Comment 2 Michele Calgaro 2018-11-12 06:55:58 CST 
Hi Mr. Obata-san,
I have seen you have registered in our TGW, so I have added you to the contributor group. You should now be able to create PR to propose code changes/fixes.
Whatever contribution you can make (even small) is more than welcome :-)
Comment 3 OBATA Akio 2018-12-05 20:36:06 CST 
I have patches, but I don't have so much free time for such kind of jobs now.
(need to dig my pgp key, setup to clone the git repository and so on)

I hope to do such things in the next year...
Comment 4 Michele Calgaro 2018-12-06 09:19:39 CST 
> I have patches, but I don't have so much free time for such kind of jobs now.
> (need to dig my pgp key, setup to clone the git repository and so on)
> I hope to do such things in the next year...

No problem Mr. Obata-san, your account is there, so whenever you wish and have time to contribute, feel free to do so. Every little helps :-)
BTW, you don't necessarily need a pgp key to access TGW, you can simply clone with user id and password if you wish.

Also for this specific bug, Slavek has created a PR on TGW that will probably be merge soon.
https://mirror.git.trinitydesktop.org/gitea/TDE/tde-common-admin/pulls/3
Comment 5 Michele Calgaro 2018-12-09 09:06:16 CST 
PR was merged.