3014 – KRFB: A function of appending new symbols to the actual X-server keymap

By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

Bug 3014 - KRFB: A function of appending new symbols to the actual X-server keymap

Summary: KRFB: A function of appending new symbols to the actual X-server keymap

Status:	PATCHAVAIL

Alias:	None

Product:	TDE
Classification:	Unclassified
Component:	tdenetwork (show other bugs)
Version:	R14.0.x [Trinity]
Hardware:	All Linux

Importance:	P5 enhancement
Assignee:	Timothy Pearson

URL:

Depends on:
Blocks:	3206 R14.0.7
	Show dependency tree / graph

Reported:	2019-05-05 01:24 CDT by Roman Savochenko
Modified:	2023-06-18 08:52 CDT (History)
CC List:	4 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
The new function of registering-appending the new entered keys (2.17 KB, patch) 2019-05-05 01:24 CDT, Roman Savochenko	Details \| Diff
Deleting the entered additional keys at achievement the limit and at exit. (2.95 KB, patch) 2020-01-06 13:17 CST, Roman Savochenko	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Roman Savochenko 2019-05-05 01:24:09 CDT

Created attachment 2915 [details]
The new function of registering-appending the new entered keys

The modern X-server (seems after xorg-server 1.10) changed itself behavior in treating keymaps, what impact to VNC and made impossible to type into VNC for different from the base-first keyboard layout keys.

x11vnc, far ago, resolved this behavior appending a function of registering-appending the new entered keys, which clean, together with restoring all other layouts, at the VNC session finish.

So, I have appended this new function to KRFB by this included patch.

Comment 1 Michele Calgaro 2019-05-08 07:19:21 CDT

Hi Roman, thanks. 
Can you create a PR in TGW? It is much simpler for testing, author ownership and interactino if necessary

Comment 2 Roman Savochenko 2019-08-04 08:26:22 CDT

(In reply to Michele Calgaro from comment #1)
> Hi Roman, thanks. 
> Can you create a PR in TGW? It is much simpler for testing, author ownership
> and interactino if necessary

I cannot push my commit to the GIT:
roman@roman:~/tmp/tdenetwork$ git push
Username for 'https://mirror.git.trinitydesktop.org': roman
Password for 'https://roman@mirror.git.trinitydesktop.org':
remote: User permission denied
fatal: unable to access 'https://mirror.git.trinitydesktop.org/gitea/TDE/tdenetwork.git/': The requested URL returned error: 403

Comment 3 Roman Savochenko 2019-08-04 08:58:39 CDT

(In reply to Roman Savochenko from comment #2)
> Password for 'https://roman@mirror.git.trinitydesktop.org':
This must be in some branch, what I have did: https://mirror.git.trinitydesktop.org/gitea/TDE/tdenetwork/pulls/12

Comment 4 Michele Calgaro 2019-08-04 10:34:44 CDT

Thanks Roman and welcome to TGW and TWTW :-)

Comment 5 Michele Calgaro 2019-08-13 20:33:04 CDT

Fixed by tdenetwork#12.

Comment 6 Roman Savochenko 2019-08-30 04:37:06 CDT

(In reply to Michele Calgaro from comment #4)
> Thanks Roman and welcome to TGW and TWTW :-)

Yes, TGW seems work, due to I have got this function on the last builds, and I am going to prepare other my patches in such way.

But TWTW seems wrong, due my last-test changes into tdebase/ksmserver don't appear into the ksmserver.mo file of the last package tde-i18n-uk-trinity !!!

To control I am seeing to the messages "<qt><p>Log out of the current session and turn off the computer.</p></qt>" which is presented into https://mirror.git.trinitydesktop.org/weblate/zen/tdebase/ksmserver/uk/?type=all but is missed into ksmserver.mo.

Must I open a new bug for this issue?

Comment 7 Michele Calgaro 2019-08-30 09:07:26 CDT

Hi Roman,
AFAICT, TWTW works on .pot and .po files. I have added Slavek to this bug, so he can add more comments since he is the one who setup TWTW and so has better knowledge than me.

Comment 8 Slávek Banko 2019-08-30 09:24:00 CDT

You can see that your translations were pushed into the master branch and then merged into r14.0.x branch:

https://mirror.git.trinitydesktop.org/gitea/TDE/tde-i18n/commit/a4b8c63e67
https://mirror.git.trinitydesktop.org/gitea/TDE/tde-i18n/src/branch/r14.0.x/tde-i18n-uk/messages/tdebase/ksmserver.po

Everything seems to work as it should.

Because "mo" files are created during the build of the tde-i18n package, you can see that your translations are part of the r14.1.0~pre and r14.0.7~pre packages.

Comment 9 Roman Savochenko 2019-08-30 12:34:30 CDT

(In reply to Slávek Banko from comment #8)
> You can see that your translations were pushed into the master branch and
> then merged into r14.0.x branch:
> 
> https://mirror.git.trinitydesktop.org/gitea/TDE/tde-i18n/commit/a4b8c63e67
> https://mirror.git.trinitydesktop.org/gitea/TDE/tde-i18n/src/branch/r14.0.x/
> tde-i18n-uk/messages/tdebase/ksmserver.po

Where we can see this sample message is commented:
#~ msgid ""
#~ "<qt><p>Log out of the current session and turn off the computer.</p></qt>"
#~ msgstr "<qt><p>Завершити поточний сеанс та вимкнути комп'ютер.</p></qt>"

But it is actual one, please see the image?

Comment 10 Roman Savochenko 2019-08-30 12:37:53 CDT

(In reply to Roman Savochenko from comment #9)
> Where we can see this sample message is commented:
> #~ msgid ""
> #~ "<qt><p>Log out of the current session and turn off the
> computer.</p></qt>"
> #~ msgstr "<qt><p>Завершити поточний сеанс та вимкнути комп'ютер.</p></qt>"
> 
> But it is actual one, please see the image?
http://ftp.oscada.org/Misc/ExitingDialog.png

Comment 11 Roman Savochenko 2019-09-08 12:17:14 CDT

Let's observe this problem on the two sample messages, where they both present in the real source code:
1. "<qt><p>Log out of the current session and turn off the computer.</p></qt>"
2. "&Freeze Computer"

So I have two levels of difference between TWTW and the end file ksmserver.mo:
1. In TWTW (https://mirror.git.trinitydesktop.org/weblate/zen/tdebase/ksmserver/uk/?type=all) I have 58 translated messages with translation the first sample (44) but without the second sample in whole.
2. In the GIT branch (https://mirror.git.trinitydesktop.org/gitea/TDE/tde-i18n/src/branch/r14.0.x/tde-i18n-uk/messages/tdebase/ksmserver.po) I have 61 translated messages and 10 commented, where the first sample is as commented one and the second sample is as true translated.
3. In the final ksmserver.mo (tde-i18n-uk-trinity 4:14.0.7~pre100-0debian10.0.0+3) I have only 54 messages, where both the first and the second sample are missed!

Comment 12 Roman Savochenko 2020-01-06 13:17:25 CST

Created attachment 2937 [details]
Deleting the entered additional keys at achievement the limit and at exit.

The last patch has problems with satiation the additional keys entry, so after entry about 20 additional keys to the main keyboard layout they are not appeared more, due to the keyboard layout is limited in 255 keys, where 20 positions are free only.

So, I have improved the code by deleting the entered additional keys at achievement the limit and at exit. And it works now properly.