By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 3073 - QtCurve 1.7.1 backported to Triniry, but no config module and image background does not work
Summary: QtCurve 1.7.1 backported to Triniry, but no config module and image backgroun...
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: qt3 (show other bugs)
Version: R14.0.x [Trinity]
Hardware: All All
: P5 normal
Assignee: Michele Calgaro
URL:
Depends on:
Blocks: R14.0.9
  Show dependency treegraph
 
Reported: 2020-02-15 11:10 CST by TCH
Modified: 2020-11-30 05:50 CST (History)
4 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:


Attachments
QtCurve 1.7.1 changes backporting patch for Trinity's QtCurve 1.6.2 (46.07 KB, patch)
2020-02-15 11:10 CST, TCH
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description TCH 2020-02-15 11:10:28 CST
Created attachment 2939 [details]
QtCurve 1.7.1 changes backporting patch for Trinity's QtCurve 1.6.2

Hello.

I've just backported the changes of QtCurve 1.7.0 and 1.7.1 to Trinity's version (1.6.2) of QtCurve. (http://mirror.git.trinitydesktop.org/gitea/TDE/tde-style-qtcurve)

I attached the patch.

I've tested the built qtcurve.so and qtcurve.la and they are working. However, i've noticed, that the configuration module does not build. Not even with the original sources of 1.6.2.

Also i am unable to set the background image for panels and menus from the config file. A decade ago i had a converstation with original author Craig Drummond here: https://www.cinnamon-look.org/p/1005552/show/page/21
He advised me what to do, but 1.6.2 did not supported those options; it was introduced in 1.7.0, that's why i backported it, but it still not works.

Any ideas on that?
Comment 1 Michele Calgaro 2020-02-15 20:38:00 CST
Thanks TCH, at a first quick look, the patch looks very clean. Good job. 
I have added you to the list of contributors on TGW since you already have an account there. Could you create a PR with your code? It is much easier to work and discuss further on TGW than on bugszilla :-)
See here for a guide o nhow to do that.
https://wiki.trinitydesktop.org/TDE_Gitea_Workspace#To_contribute_code_changes

PS: I use QtCurve, so I will take a look at merging this patch i nnear future once on TGW.
Comment 2 TCH 2020-02-16 04:45:53 CST
root@Csabi:/tmp/tde-style-qtcurve-1.7.1# git push -u master/tde-style-qtcurve
fatal: 'master/tde-style-qtcurve' does not appear to be a git repository
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

---

I copied this ticket to gitea.
Comment 3 Michele Calgaro 2020-02-16 05:37:24 CST
From your local branch (which should be different from master), try:
git push origin HEAD
and see if it still gives you an error.
In any case I have note yuor issue on TGW, so it won't get overlooked ;-)
Comment 4 TCH 2020-02-16 06:04:59 CST
root@Csabi:/tmp/tde-style-qtcurve-1.7.1# git push origin HEAD
Username for 'https://scm.trinitydesktop.org': tch
Password for 'https://tch@scm.trinitydesktop.org':
remote: invalid credentials
fatal: Authentication failed for 'https://scm.trinitydesktop.org/gitea/TDE/tde-style-qtcurve.git/'

root@Csabi:/tmp/tde-style-qtcurve-1.7.1# git push origin HEAD
Username for 'https://scm.trinitydesktop.org': tch@protonmail.com
Password for 'https://tch@protonmail.com@scm.trinitydesktop.org':
remote: invalid credentials
fatal: Authentication failed for 'https://scm.trinitydesktop.org/gitea/TDE/tde-style-qtcurve.git/'

---

No luck. Never mind. Any ideas about the config module not building or why the image as window/menu background is not working?
Comment 5 Slávek Banko 2020-02-20 18:30:51 CST
(In reply to TCH from comment #4)
> root@Csabi:/tmp/tde-style-qtcurve-1.7.1# git push origin HEAD
> Username for 'https://scm.trinitydesktop.org': tch
> Password for 'https://tch@scm.trinitydesktop.org':
> remote: invalid credentials
> fatal: Authentication failed for
> 'https://scm.trinitydesktop.org/gitea/TDE/tde-style-qtcurve.git/'
> 
> root@Csabi:/tmp/tde-style-qtcurve-1.7.1# git push origin HEAD
> Username for 'https://scm.trinitydesktop.org': tch@protonmail.com
> Password for 'https://tch@protonmail.com@scm.trinitydesktop.org':
> remote: invalid credentials
> fatal: Authentication failed for
> 'https://scm.trinitydesktop.org/gitea/TDE/tde-style-qtcurve.git/'
> 
> ---
> 
> No luck. Never mind. Any ideas about the config module not building or why
> the image as window/menu background is not working?

I don't know how carefully you read the instructions on the TGW wiki page, but the address you used - scm.trinitydesktop.org - is not correct. At this address is a Gitea instance that is read-only for everyone.

On the TGW wiki page you can read that you need to use mirror.git.trinitydesktop.org to push your branch.
Comment 6 TCH 2020-02-21 04:19:52 CST
I only read the linked section (https://wiki.trinitydesktop.org/TDE_Gitea_Workspace#To_contribute_code_changes) which did not contain any kind of URL. I've cloned QtCurve from https://scm.trinitydesktop.org/gitea/TDE/tde-style-qtcurve.git/ and had no idea that it is read-only. Thanks for pointing out, next time i'll use the other URL.
Comment 7 Michele Calgaro 2020-04-26 08:03:50 CDT
@tch: I have posted a few comments on TGW about this and need your feedback so that I can merge the patch. Letting you know here in case you don't follow the TGW issue.
Comment 8 TCH 2020-04-26 08:28:48 CDT
I do follow, but i had other stuff to do.
Comment 9 Michele Calgaro 2020-11-29 02:57:21 CST
@TCH:
As per bug 2936, 
Qt 1.8.5 is now part of TDE. 
The issue with background not working is tracked in https://mirror.git.trinitydesktop.org/gitea/TDE/tde-style-qtcurve/issues/3.

Would it be ok to close this bug report off?
Comment 10 TCH 2020-11-29 08:35:01 CST
Yes, please close it.
Comment 11 Michele Calgaro 2020-11-30 05:50:41 CST
Thanks!