By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 3122 - libr build attempts to write to the source directory
Summary: libr build attempts to write to the source directory
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: other (any) (show other bugs)
Version: R14.0.x [Trinity]
Hardware: Other Linux
: P5 normal
Assignee: Timothy Pearson
URL:
Depends on:
Blocks: R14.0.9
  Show dependency tree / graph
 
Reported: 2020-06-08 20:25 CDT by aneejit1
Modified: 2020-06-10 11:35 CDT (History)
4 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
Patch for libr source directory write (942 bytes, patch)
2020-06-08 20:25 CDT, aneejit1 		Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description aneejit1 2020-06-08 20:25:55 CDT 
Created attachment 2965 [details]
Patch for libr source directory write

Once configured, the libr make process tries to write to the man3 directory in the source tree. Since this is stored in a location where the build id cannot write to it, the build fails.

Attached is a fix to man/CMakeLists.txt which causes the write to go to the binary directory.

This is found in the 14.0.8 release. I've cloned the current version from git and built successfully using this patch.
Comment 1 Slávek Banko 2020-06-09 05:58:54 CDT 
Great, that's obviously bug, and your fix looks good. Please, can you register an account at TDE Gitea Workspace (TGW) and put your patch there as a pull request?

Note: To create pull requests, we prefer the shared collaboration with branches model. See https://wiki.trinitydesktop.org/TDE_Gitea_Workspace
Comment 2 Michele Calgaro 2020-06-09 10:45:43 CDT 
Once registered on TGW, let us know your username, we need to add you as contributor before you can create a PR :-)
Comment 3 aneejit1 2020-06-09 14:32:39 CDT 
OK, I'm signed up to TGW as "aneejit1". Please do your magic!
Comment 4 Slávek Banko 2020-06-09 14:55:04 CDT 
(In reply to aneejit1 from comment #3)
> OK, I'm signed up to TGW as "aneejit1". Please do your magic!

Great - welcome to the TDE team Contributors, you can now create pull requests.
Comment 5 aneejit1 2020-06-09 17:05:01 CDT 
Clone, checked out, amended, committed, pushed and pulled. Hopefully I've done the admin side the right way. It's in the system as branch "bug/3122/write-to-source-fix".
Comment 6 Slávek Banko 2020-06-10 11:35:28 CDT 
Fixed in pull-request TDE/libr#3 https://mirror.git.trinitydesktop.org/gitea/TDE/libr/pulls/3