By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 3154 - Holiday regions do not work
Summary: Holiday regions do not work
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: tdepim (show other bugs)
Version: R14.0.x [Trinity]
Hardware: Other All
: P5 normal
Assignee: Michele Calgaro
URL:
Depends on:
Blocks: R14.0.9
  Show dependency tree / graph
 
Reported: 2020-08-03 01:59 CDT by linux
Modified: 2020-08-24 09:40 CDT (History)
3 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
Kontact holidays screenshot with 14.0.8 libtdepim1a-trinity (105.01 KB, image/png)
2020-08-13 07:17 CDT, linux 		Details
Kontact holidays screenshot with 14.0.9 libtdepim1a-trinity (108.96 KB, image/png)
2020-08-13 07:18 CDT, linux 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description linux 2020-08-03 01:59:52 CDT 
Holidays from holiday regions in Kontact/KOrganizer stopped working some time ago. Looks like they're ignored - not visible in calendar.

I'm using R14.0.9 development.
Comment 1 Michele Calgaro 2020-08-12 23:14:09 CDT 
Hi there,
can you add some more info about this bug? I am not sure we understand what is wrong to be honest.
Comment 2 linux 2020-08-13 06:25:49 CDT 
In Kontact, you select a holiday region Settings->Configure Calendar->Time & Date->Use holiday region.

Then the holidays should be visible in calendar - the day number should be red and a tooltip with holiday name should appear when mouse cursor is over it.

No matter what region I select, there are no holidays visible in the calendar anymore. It used to work a couple of months ago.

The data is stored in /opt/trinity/share/apps/libkholidays
Comment 3 linux 2020-08-13 07:17:47 CDT 
Created attachment 2987 [details]
Kontact holidays screenshot with 14.0.8 libtdepim1a-trinity

Downgrading libtdepim1a-trinity to 14.0.8 (together with tdepim-trinity) fixes the problem.
Comment 4 linux 2020-08-13 07:18:45 CDT 
Created attachment 2988 [details]
Kontact holidays screenshot with 14.0.9 libtdepim1a-trinity

Broken with 14.0.9 libtdepim1a-trinity
Comment 5 Michele Calgaro 2020-08-13 09:04:34 CDT 
OK, thanks. Crystal clear! Sounds like a regression at first sight.
Comment 6 Michele Calgaro 2020-08-17 23:53:39 CDT 
This is caused by this commit:
https://mirror.git.trinitydesktop.org/cgit/tdepim/commit/?id=1e14bf4b2e83d2bdcf7d8debc00bf584c6788c98
Comment 7 Michele Calgaro 2020-08-19 05:14:17 CDT 
tdepim #46 should solve bug 3120 without causing this one.
https://mirror.git.trinitydesktop.org/gitea/TDE/tdepim/pulls/46
Comment 8 Michele Calgaro 2020-08-19 20:22:14 CDT 
Solved by the mentionied PR.
Comment 9 Michele Calgaro 2020-08-20 20:30:06 CDT 
Updated packages have been built, so you should be able to double check it is ok now.
Comment 10 linux 2020-08-21 13:50:04 CDT 
Yes, it works again! Thanks for fixing it quickly.
Comment 11 Michele Calgaro 2020-08-24 09:40:28 CDT 
Thanks for reporting it :-)