By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 508 - Kickoff menu unstable
Summary: Kickoff menu unstable
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: tdebase (show other bugs)
Version: 3.5.12 [Trinity]
Hardware: amd64 Linux
: P5 minor
Assignee: Timothy Pearson
URL:
: 281 (view as bug list)
Depends on:
Blocks: 281
  Show dependency tree / graph
 
Reported: 2011-09-09 16:26 CDT by Francois Andriot
Modified: 2012-10-19 15:20 CDT (History)
4 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
patch (333 bytes, patch)
2011-10-16 23:14 CDT, Calvin Morrison 		Details | Diff
FIX ALL THE THINGS! (12.32 KB, patch)
2011-11-18 15:33 CST, Calvin Morrison 		Details | Diff
FIX THE BROKEN PATCH! (12.37 KB, patch)
2011-11-19 10:45 CST, Calvin Morrison 		Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Francois Andriot 2011-09-09 16:26:49 CDT 
Hello,
I'm currently using TDE 3.5.12 compiled on RHEL6.
By default, kmenu is showing the classic KDE menu, which works very well.

But when I switch to "Kickoff" menu, I have 2 issues:

1) The "K" button icon is automatically changed to the default KDE icon, and the word "Go!" is displayed alongside the button, even though I chose a custom icon and unchecked the option "Display text in K menu button".

2) Randomly (but quickly) when browsing the Kickoff menu, it hangs. Then the "kicker" process eats 100% cpu and I have to manually kill it and restart it.

Switching back to the classic menu makes both issues vanish ...

Note: I have the exact same behaviour with the current 3.5.13 SVN build

Thanks
Comment 1 Timothy Pearson 2011-09-09 16:34:44 CDT 
The kickoff menu is provided merely as a convenience and is not officially supported at this time (due to its similarity to KDE4, many Trinity users do not use it), so don't expect much action on this bug report. :-)

That being said, if you can attach gdb to the kicker process during one of the 100% CPU hangs, break the process, then generate a backtrace, that would greatly help in repairing the problem.

Thanks!
Comment 2 Calvin Morrison 2011-10-16 23:14:29 CDT 
Created attachment 104 [details]
patch
Comment 3 Calvin Morrison 2011-10-16 23:14:49 CDT 
it seems to fix it for me. please test!g
Comment 4 Francois Andriot 2011-10-17 12:27:32 CDT 
Hello, it seems much more stable now, thanks for the patch.

I still have the wrong K menu icon though.
Comment 5 Calvin Morrison 2011-10-17 14:27:03 CDT 
Hi,

I have looking into that as well. I actually am quite confused as to how kickoff is dealing with it as opposed to kicker. Hopefully I can sort it out. 

(also bug 281 is fixed by this)
Comment 6 Calvin Morrison 2011-10-18 10:55:11 CDT 
I am making much progress. I have kickoff converted over to the regular button, removing it's terribly written and bloaty button style. It follows the regular button icon defined in the panel config window.

Right now I am hung up on one last function, once I work this out it should be ready to go. 

Currently the button is popping up in the wrong spot, because I can't get it to adjust properly, because some function isn't returning the right widget. the problem is that function is also used by the regular KMenu.

Either way I should have it resolved today or tomorrow.


Calvin Morrison
Comment 7 Timothy Pearson 2011-10-23 14:56:18 CDT 
Any progress on this bug?  Code freeze should occur today or tomorrow, so if the final patch is not uploaded today it will have to wait about a year for the next release.
Comment 8 Calvin Morrison 2011-11-18 15:33:16 CST 
Created attachment 132 [details]
FIX ALL THE THINGS!
Comment 9 Calvin Morrison 2011-11-18 15:34:29 CST 
For some time I have been working on Kickoff (the alternate panel under
Kicker). I have resolved a few problems and have created a patch to fix up
the problems. It closes at least bug 508 and 281

First of all, KNewButton is a terrible and bloated implementation of the
KButton class, with animations that didn't work or do anything really. it
does however have things that are required for the kickoff menu.

So I stripped all the crap out of KNewButton and got it to work with the
same settings that the regular kbutton does. This also fixes a bug with
transparency that wasn't reported.

Also I fixed the problem with the "computer" tab that was causing a endless
loop.
Comment 10 Francois Andriot 2011-11-19 03:00:07 CST 
Hello, thanks for your work on kickoff :)

Alas, when I apply the attached patch, I get:
/usr/bin/patch: **** malformed patch at line 46: @@ -82,28 +84,15 @@
What is wrong here ?
Comment 11 Calvin Morrison 2011-11-19 10:45:52 CST 
Created attachment 138 [details]
FIX THE BROKEN PATCH!

this should work >_>
Comment 12 Francois Andriot 2011-11-19 12:54:20 CST 
Thanks, I confirm the patch is applying correctly.
From what I've seen so far, the patch solves the issues with no regression.
Comment 13 Timothy Pearson 2012-01-11 13:09:47 CST 
Committed in GIT hash 6f32bfd.

Thanks for reporting, and for the patch!
Comment 14 Timothy Pearson 2012-01-11 17:05:20 CST 
*** Bug 281 has been marked as a duplicate of this bug. ***