By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 538 - gtk-qt-engine contains deprecated components.
Summary: gtk-qt-engine contains deprecated components.
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: other (any) (show other bugs)
Version: 3.5.13 [Trinity]
Hardware: All Linux
: P5 enhancement
Assignee: Timothy Pearson
URL:
Depends on:
Blocks:
 
Reported: 2011-10-12 11:18 CDT by Calvin Morrison
Modified: 2012-10-19 15:52 CDT (History)
2 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
gtk-qt engine patch. (3.15 KB, patch)
2011-10-12 11:18 CDT, Calvin Morrison 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Calvin Morrison 2011-10-12 11:18:06 CDT 
Created attachment 98 [details]
gtk-qt engine patch.

our gtk-qt-engine contains deprecated code. Previously we removed some of the pieces that caused errors, hopefully this will help keep it clean for the future.

I have removed the Bonobo references, because onobo has been deprecated for some time. It was actually a interesting components system, similar to kparts. Either way I have removed it from our CMakeLists as well as the code. Compiles well without it. Had alternative code in the IFDEF anyway, so it didn't really matter.

I also renamed a poorly named list. It was named child1 (unclear because child referenced a widget) and renamed it child_list. This will keep the code clean.

I also removed the reference to the deprecated GtkBoxChild. That was deprecated in 2.24.

Cheers

Calvin Morrison
Comment 1 Timothy Pearson 2011-10-14 21:09:05 CDT 
The repair portion of the attached patch has been committed to SVN in revision 1258949.  However, I have chosen not to remove bonobo support, as I would prefer not to break legacy applications just to have slightly "cleaner" source code.