By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 586 - 3.5.13 regression: kio-locate-trinity doesn't show any results in Konqueror
Summary: 3.5.13 regression: kio-locate-trinity doesn't show any results in Konqueror
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: tdeaddons (show other bugs)
Version: 3.5.13 [Trinity]
Hardware: amd64 Debian Squeeze
: P5 normal
Assignee: Slávek Banko
URL:
Depends on:
Blocks:
 
Reported: 2011-11-07 17:20 CST by waissi
Modified: 2012-10-12 08:10 CDT (History)
4 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
Fix handling properties of large files (1.29 KB, patch)
2012-08-19 03:16 CDT, Slávek Banko 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description waissi 2011-11-07 17:20:35 CST 
It does seem to launch locate, but nothing is shown in Konqueror.

Steps to reproduce: 

1. enter locate:[file-you-know-you-have] in Konqueror location bar.

It worked in 3.5.12.
Comment 1 Darrell 2012-08-16 12:41:38 CDT 
kio-locate is working in R14 GIT.

According to the 3.5.13 SRU etherpad (http://trinity.etherpad.trinitydesktop.org/16), Slavek has backported several patches to kio-locate. If Slavek confirms kio-locate is functioning in 3.5.13 SRU then we can tag this bug report as resolved.
Comment 2 Slávek Banko 2012-08-16 20:43:42 CDT 
Yes, I can confirm that it works in v3.5.13-sru. Except for one detail - for files larger than 2 GiB states meaningless size.
Comment 3 Darrell 2012-08-16 22:45:04 CDT 
Searching the web reveals that at one time slocate/updatedb had a bug where files > 2GB were not listed. The bug seems to be still active. Interestingly, I can see the file names in the slocate.db. Yet they do not appear when running the locate command.

The problem then is slocate and not kio-locate. I don't know what is wrong with slocate and >2GB file sizes.

Because kio-locate is working in 3.5.13 SRU and R14, I'm closing this bug report as resolved.
Comment 4 Darrell 2012-08-16 23:07:09 CDT 
For anybody interested, the updatedb command must be run with the "-l 0" option to force the locate command to display files > 2GB. I have no idea why displaying files > 2GB is considered a security problem.
Comment 5 Slávek Banko 2012-08-17 01:21:58 CDT 
On Debian I have installed 'mlocate'. Files over 2 GiB I see in kio-locate results, but their size displayed in the file properties (and the tooltip) is meaningless. The reported overall size of the found files is of course also meaningless. So I believe it is an error in kio-locate. Maybe using long instead of long long?
Comment 6 Darrell 2012-08-17 12:47:33 CDT 
Slackware uses slocate and I lack the time right now to experiment with mlocate.

Try a "long -> long long" patch and see what happens.
Comment 7 Slávek Banko 2012-08-19 03:16:13 CDT 
Created attachment 791 [details]
Fix handling properties of large files

I do not know if you meant already existing patch,
but I tried to prepare a new one.

Note: patched bug appeared only on 32bit.
Comment 8 Francois Andriot 2012-08-22 12:36:38 CDT 
Hello, using kio_locate 3.5.13-sru on top of 3.5.13 installation still does not work at all. (I'm talking about the original bug report)

Are you aware of what (and where ...) has changed to resolve the bug for you ? Something in kdelibs ?
Comment 9 Darrell 2012-08-22 20:10:49 CDT 
I am confused.

slocate/locate will not list files > 2GB unless the -l0 option is used with the updatedb command to build the database. When I use that option, then running the locate command in a terminal window lists files > 2GB. Because locate then lists such files, kio-locate also lists such files.

When I run updatedb without the -l0 option, then the locate command does not list files > 2GB and neither does kio-locate.

I rebuilt kio-locate with the patch but I see no way of testing. Either the locate command lists files >2GB or does not. kio-locate only imitates the underlying behavior of the locate command.
Comment 10 Slávek Banko 2012-08-22 20:28:43 CDT 
Yes, kio-locate not affect updatedb behavior. However, if your locate "know" files >2GiB, then kio-locate on a 32bit system lists this files with nonsensical sizes. Attached patch fixes just this.
Comment 11 Darrell 2012-08-22 21:07:19 CDT 
Okay, I see. Yes, without the patch file sizes are HUGE and unrealistic. With the patch the file sizes are correct.

The patch works here, Slackware 13.1 32-bit.
Comment 12 Slávek Banko 2012-08-24 19:40:12 CDT 
Handling properties of large files fixed in GIT hash efcd2f6e

François, unfortunately I can not say exactly which patch of kdelibs or kdebase helped to solve functionality of kio-locate. It was no consciously included just for that. Please, can we close this bug without this knowledge?
Comment 13 Slávek Banko 2012-10-11 13:21:38 CDT 
François,
can you confirm whether, is in Fedora (and other RPM distros) in 3.5.13.1 this problem also fixed?
Comment 14 Francois Andriot 2012-10-11 15:04:27 CDT 
It looks like it works fine with 3.5.13.1, including files >2GB .