By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 618 - KDM Log File
Summary: KDM Log File
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: tdebase (show other bugs)
Version: R14.0.0 [Trinity]
Hardware: All All
: P1 minor
Assignee: Timothy Pearson
URL:
Depends on:
Blocks:
 
Reported: 2011-11-14 10:30 CST by Darrell
Modified: 2012-10-19 15:48 CDT (History)
2 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:


Attachments
Trival fixes to kdm help options and readme (1.30 KB, patch)
2012-01-21 14:47 CST, Darrell
Details | Diff
Patch updated with new renaming (1.30 KB, patch)
2012-01-26 18:00 CST, Darrell
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darrell 2011-11-14 10:30:48 CST
Trinity KDM defaults to using a log file named kdm.log, the name of which would conflict with KDE 4. The kdebase/kdm/backend/error.c source file contains the hard-coding at line 102:

sprintf( buf, "/var/log/%s.log", prog );

According the kdebase/kdm/README file, there is a command line startup option to change the log name named -logfile. According to kdm --help, the README is incorrect. The kdm --help options shows the correct option is -error. Although end users can use the -error option to change the log name and avoid conflicts with KDE 4, the hard-coded default should be changed.

The README file should be updated as well.
Comment 1 Timothy Pearson 2012-01-21 13:21:20 CST
It would probably be a good idea to rename kdm completely to tdm.  Rationale includes the fact that this is not a highly user-visible change (who runs kdm directly from the command line!?) and the fact that most distribution startup scripts use the name of the executable, causing a conflict.
Comment 2 Darrell 2012-01-21 13:44:38 CST
Do you object to renaming? If not, would you provide me with a punch list of sorts similar to how you approached renaming kdesu to tdesu. I'm sure there are many connections that have to be covered.

I'd like to tinker with this --- so I can learn a bit more. :)
Comment 3 Timothy Pearson 2012-01-21 14:10:30 CST
No, I do not object.  However, I have a fully automated way to do that, and it takes a good day or two to run.  Manually it could take a LOT longer to work out all the possible bugs. ;-)

Raising to BLOCKER as this needs to be done before R14.0.0 is released.
Comment 4 Darrell 2012-01-21 14:47:27 CST
Created attachment 284 [details]
Trival fixes to kdm help options and readme

Okay. I'll let you run your super duper magical conversion scripts. :)

In the mean time I'll submit this nominal patch to clarify the kdm options and readme file. With respect to my original post in this bug report, the code logic shows both -error and -logfile as being legitimate ways to specify an alternate log file. I also did some minor grammar fixes.
Comment 5 Timothy Pearson 2012-01-23 15:01:59 CST
This should now be fixed in GIT.
Comment 6 Darrell 2012-01-26 15:21:05 CST
Woa! Lots of work! :)

I am building and testing now with GIT 2838.

Note: The patch I submitted still needs to be applied to ensure the README and tdm --help text is technically correct. :)
Comment 7 Timothy Pearson 2012-01-26 15:44:41 CST
Help text still needs to be updated per comments above.
Comment 8 Darrell 2012-01-26 18:00:05 CST
Created attachment 295 [details]
Patch updated with new renaming

Patch is now updated with new renaming. :)
Comment 9 Darrell 2012-01-27 14:56:58 CST
Initial test in GIT 2838 indicates no problems. Do we have any kind of test plan for tdm?

tdm.log is filled with these messages:

QSettings::sync: filename is null/empty
QSettings: error creating /tmp/0681627453/.qt
QSettings: failed to open file '/tmp/0681627453/.qt/qt_plugins_3.3rc'
QSettings::sync: filename is null/empty
QSettings: error creating /tmp/0681627453/.qt
QSettings: failed to open file '/tmp/0681627453/.qt/qt_plugins_3.3rc'
QSettings::sync: filename is null/empty
QSettings: error creating /tmp/0681627453/.qt
QSettings: failed to open file '/tmp/0681627453/.qt/qt_plugins_3.3rc'
QSettings::sync: filename is null/empty
QSettings: error creating /tmp/0681627453/.qt
QSettings: failed to open file '/tmp/0681627453/.qt/qt_plugins_3.3rc'
QSettings::sync: filename is null/empty
QSettings: error creating /tmp/0681627453/.qt
QSettings: failed to open file '/tmp/0681627453/.qt/qt_plugins_3.3rc'
QSettings::sync: filename is null/empty
QSettings: error creating /tmp/0681627453/.qt
QSettings: failed to open file '/tmp/0681627453/.qt/qt_plugins_3.3rc'
QSettings::sync: filename is null/empty
QSettings: error creating /tmp/0681627453/.qt
QSettings: failed to open file '/tmp/0681627453/.qt/qt_plugins_3.3rc'
QSettings::sync: filename is null/empty
QSettings: error creating /tmp/0681627453/.qt
QSettings: failed to open file '/tmp/0681627453/.qt/qt_plugins_3.3rc'
QSettings::sync: filename is null/empty
QSettings: error creating /tmp/0681627453/.qt
QSettings: failed to open file '/tmp/0681627453/.qt/qt_plugins_3.3rc'
QSettings::sync: filename is null/empty

If desired then I will open a new bug report against those messages.
Comment 10 Darrell 2012-02-25 00:36:58 CST
Patch merged in GIT hash 618e7f195065cdc19b86f4c1ffe6b94d2b6a64ae.