By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 752 - kdepim: Fix inadvertent 'tqt' changes
Summary: kdepim: Fix inadvertent 'tqt' changes
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: tdepim (show other bugs)
Version: R14.0.0 [Trinity]
Hardware: Other Other
: P1 major
Assignee: Timothy Pearson
URL:
Depends on:
Blocks:
 
Reported: 2011-12-18 11:33 CST by Darrell
Modified: 2012-10-19 15:50 CDT (History)
2 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name: kdepim

Attachments
Fix status bar problem (116.11 KB, patch)
2011-12-18 11:33 CST, Darrell 		Details | Diff
Fix inadvertent tqt conversions (691.87 KB, patch)
2011-12-18 11:37 CST, Darrell 		Details | Diff
Fix inadvertent tqt conversions (521.69 KB, patch)
2011-12-18 11:38 CST, Darrell 		Details | Diff
Revised patch for fixing inadvertent changes (150.72 KB, patch)
2012-01-13 10:02 CST, Darrell 		Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darrell 2011-12-18 11:33:48 CST 
Created attachment 229 [details]
Fix status bar problem

Throughout kdepim many slotStatus* and similar functions inadvertently were changed to sloStatus*. Although mostly consistent with the inadvertent changes to cause only nominal trouble, the mistake likely is the cause of some kdepim related bug reports, such as the akregator status bar not working when the mouse pointer hovers over a link.

The license notifications and many comments in the source files were inadvertently changed to TQt references rather than remaining Qt. This type of reverse cleanup patch likely needs to be applied to the entire TDE source tree. :)
Comment 1 Darrell 2011-12-18 11:37:48 CST 
Created attachment 230 [details]
Fix inadvertent tqt conversions
Comment 2 Darrell 2011-12-18 11:38:43 CST 
Created attachment 231 [details]
Fix inadvertent tqt conversions

Patch was split into two because of 1MB file size limitation.
Comment 3 Timothy Pearson 2012-01-11 18:04:57 CST 
This does not apply cleanly at all against the latest GIT.

Can you please update it?
Comment 4 Darrell 2012-01-11 19:23:24 CST 
Which patch? All three?
Comment 5 Darrell 2012-01-13 10:02:30 CST 
Created attachment 274 [details]
Revised patch for fixing inadvertent changes

This took a while because of all the changes in GIT, but let's give this new patch a try.
Comment 6 Timothy Pearson 2012-01-13 15:10:23 CST 
(In reply to comment #5)
> This took a while because of all the changes in GIT, but let's give this new
> patch a try.

Aren't all those changes a Good Thing? ;-)

Committed to GIT in hash d497b1b.  Thanks for working on this; it considerably helps with the overall code quality.