By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 819 - automake build error: unary operator expected
Summary: automake build error: unary operator expected
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: other (any) (show other bugs)
Version: R14.0.0 [Trinity]
Hardware: Other Other
: P1 major
Assignee: Timothy Pearson
URL:
Depends on:
Blocks:
 
Reported: 2012-01-27 02:45 CST by Darrell
Modified: 2012-10-19 15:30 CDT (History)
2 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:


Attachments
patch to fix error "unary operator expected" message in automake builds (2.65 KB, patch)
2012-01-27 02:45 CST, Darrell
Details | Diff
Updated patch to reflect recent renaming efforts (2.65 KB, patch)
2012-02-16 13:31 CST, Darrell
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darrell 2012-01-27 02:45:15 CST
Created attachment 297 [details]
patch to fix error "unary operator expected" message in automake builds

I receive this error in all of my automake builds. The cause is the usual comparing a result to a non integer:

if test `$KDECONFIG --version | grep KDE | sed 's/KDE: \(...\).*/\1/'` = 3.2; then

Inspecting the entire related snippet of code reveals the tests never will pass and no longer meet the original intent. For example:

grep KDE | sed 's/KDE

needs to be changed to:

grep TDE | sed 's/TDE

Further, the new version scheme renders the old tests against "3.x" obsolete. Running kde-config now returns the following:

kde-config --version | grep TDE
TDE: R14.0.0 [DEVELOPMENT]

which will change upon official release to R14.0.0.

I wrote a patch that eliminates the errors and updates the tests relative to the new versioning scheme in GIT.

I successfully tested the patch with the following automake packages:

tdebindings
tdeaddons
tdeaccessibility
tdeutils
tdesdk
tdeadmin
tdegames
tdeedu
tdemultimedia
tdetoys
applications/gwenview
applications/k3b
applications/koffice
applications/knemo
applications/kaffeine
applications/ktorrent
applications/ksystemlog
applications/k9copy
applications/digikam
libraries/libkexiv2
libraries/libkdcraw
libraries/kipi-plugins
Comment 1 Darrell 2012-02-16 13:31:23 CST
Created attachment 351 [details]
Updated patch to reflect recent renaming efforts
Comment 2 Darrell 2012-02-16 13:47:43 CST
Although minor, this is a build issue and the bug report should be bumped to Blocker.
Comment 3 Darrell 2012-03-04 12:59:38 CST
I have been using this patch for the following modules with no noticeable problems:

applications/digikam
applications/gwenview
applications/k3b
applications/k9copy
applications/kaffeine
applications/knemo
applications/koffice
applications/konversation
applications/ksystemlog
applications/ktorrent
libraries/kipi-plugins
libraries/libkdcraw
libraries/libkexiv2
libraries/libkipi
tdeaccessibility
tdeaddons
tdeadmin
tdebindings
tdeedu
tdegames
tdemultimedia
tdetoys
tdeutils
tdewebdev

Should I push the patches for these packages?
Comment 4 Darrell 2012-04-11 09:13:41 CDT
Now that I understand how the common admin/cmake directories replicate to the entire source tree (they are sym links in the master repository), seems we can close this bug report merely by pushing one patch to the common/admin directory.

Shall I push the patch?
Comment 5 Darrell 2012-04-14 16:04:54 CDT
Patch merged in GIT hash a7f223eb. This resolves the bug report.