By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 942 - Build issue: k3b: Can't find the TQt version of the dbus-1.0 headers
Summary: Build issue: k3b: Can't find the TQt version of the dbus-1.0 headers
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: other (any) (show other bugs)
Version: R14.0.0 [Trinity]
Hardware: Other Other
: P1 critical
Assignee: Slávek Banko
URL:
Depends on:
Blocks:
 
Reported: 2012-03-27 18:02 CDT by Darrell
Modified: 2013-01-31 18:38 CST (History)
4 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:


Attachments
Patch to fix build errors (670 bytes, patch)
2012-11-03 15:25 CDT, Darrell
Details | Diff
Fix dbus-tqt and dbus-1 checking (3.79 KB, patch)
2013-01-31 14:15 CST, Slávek Banko
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darrell 2012-03-27 18:02:36 CDT
When building k3b, the configure output shows the following:

================================================
checking for the HAL... headers /usr/include/hal  libraries /usr/lib
checking for DBus... headers /usr/include/dbus-1.0 /usr/lib/dbus-1.0/include  libraries /usr/lib
checking for DBus-TQt bindings... searched but not found
Found HAL storage version 5
...
K3b - Compile HAL support                     no
K3b -     You are missing the HAL >= 0.5 headers and libraries
K3b -     or the DBus Qt bindings.
================================================

The configure process is finding libhal.h but not finding ${PREFIX}/include/dbus-1.0/.

Seems the configure process finds the distro's copy of dbus-1.0 (installed in /usr/include) but won't look in $PREFIX for the TQt version that is built for Trinity.
Comment 1 Darrell 2012-03-28 00:13:18 CDT
k3b seems to still burn without HAL support being built in. I'm bumping this down one notch.
Comment 2 Darrell 2012-04-13 18:26:22 CDT
Possibly the problem is where dbus-tqt is installed.

Consistent with the wiki instruction, I have been installing dbus-tqt to /opt/trinity and not /usr. Further reasoning is there is already a dbus-1.0 package installed in /usr by the distro (Slackware).

Closer inspection of the dbus-tqt package reveals the package is not a full dbus-1.0 package but merely adds a TQt layer to a few dbus-1.0 files.

The error message reported here is eliminated by installing dbus-tqt to /usr rather than the usual Trinity $PREFIX location. This forces the few files provided in dbus-tqt with the TQt layer to overwrite the existing files provided by the distro. This is not clarified anywhere on the wiki.

Also not clear is what impact having these files overwritten causes to the remainder of the system.

If the Trinity package is intended to be installed in /usr and overwrite the files installed by the distro, then this should be clarified in the wiki. If not, then the configure process should look in /opt/trinity/include as well as /usr/include to find both sets of header files.
Comment 3 Darrell 2012-11-03 15:25:40 CDT
Created attachment 955 [details]
Patch to fix build errors

The attached patch resolves the build failures for me on Slackware.

Before pushing to GIT somebody else needs to test to ensure the patch does not cause problems or conflicts for others.

As already mentioned, the build failures occur only when dbus-tqt is installed to a location other than /usr. Installing to a location other than /usr is necessary because installing to /usr will overwrite existing files from the distro's dbus-1 package. Doing that likely will cause conflicts with non Trinity apps, such as KDE4. Therefore a safe solution is to install dbus-tqt to a non /usr location such as /opt/trinity and then have Trinity apps build against that location.

With the patch I see the following in my configuration output:

checking for the HAL... headers /usr/include/hal  libraries /usr/lib
checking for DBus... headers /usr/include/dbus-1.0 /usr/lib/dbus-1.0/include  libraries /usr/lib
checking for DBus-TQt bindings... headers /opt/trinity/include/dbus-1.0 libraries /opt/trinity/lib
Found HAL storage version 5
...
K3b - Compile HAL support                    yes

Although a variable-driven solution seems preferable, all of the k3b configure files use hard-coded paths. Therefore my patch seems adequate.
Comment 4 Slávek Banko 2013-01-31 14:15:33 CST
Created attachment 1100 [details]
Fix dbus-tqt and dbus-1 checking

I have checked that both packages dbus-1 and dbus-tqt have pkgconfig file, and dbus-tqt has listed as dependency dbus-1. For this reason, I consider it sufficient use pkg-config for dbus-tqt.

Please, test the updated patch.
Comment 5 Francois Andriot 2013-01-31 14:54:38 CST
Attached file 1100 solves the HAL detection problem for me.
Comment 6 Darrell 2013-01-31 18:16:43 CST
I no longer can produce the error here. The package builds with no patching and no longer reproduces the error. I can't find anything obvious why I can't reproduce. Push the patch and close the report. :)
Comment 7 Slávek Banko 2013-01-31 18:38:14 CST
Fixed in GIT hash f3e58cb8 and also in v3.5.13-sru branch.