By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.
Bug 983 - PovRay 3.7 syntax highlighting for kate
Summary: PovRay 3.7 syntax highlighting for kate
Status: RESOLVED FIXED
Alias: None
Product: TDE
Classification: Unclassified
Component: tdebase (show other bugs)
Version: R14.0.0 [Trinity]
Hardware: Other Linux
: P5 enhancement
Assignee: Calvin Morrison
URL:
Depends on:
Blocks:
 
Reported: 2012-05-03 02:18 CDT by Nikolaus Klepp
Modified: 2014-01-18 19:53 CST (History)
4 users (show)

See Also:
Compiler Version:
TDE Version String:
Application Version:
Application Name:

Attachments
PovRay 3.7 language definition (22.91 KB, text/xml)
2012-05-03 02:18 CDT, Nikolaus Klepp 		Details
povray 3.7 languge definition for kate,extension of original povray.xml from tde 3.5.13.2 (30.66 KB, text/xml)
2014-01-16 08:05 CST, Nikolaus Klepp 		Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolaus Klepp 2012-05-03 02:18:52 CDT 
Created attachment 584 [details]
PovRay 3.7 language definition

Here's a new language definition for upcomming PovRay 3.7. I took it from the povray newsgroup, original text can be found here: http://news.povray.org/povray.binaries.utilities/thread/<4f4092fb%40news.povray.org>/

> syntax highlighting for kate (Message 1 to 1 of 1)  
> 
> From: James Holsenback
> Subject: syntax highlighting for kate
> Date: 19 Feb 2012 06:13:15
> Message: <4f4092fb@news.povray.org>
> 
>  recently changed editors and missed the syntax highlighting ... 
> searching only came up with versions with deprecated (language.dtd) 
> entries and they didn't even load. I cloned 
> /usr/share/kde4/katepart/syntax/cpp.xml and updated the keywords section 
> with v3.7 RC4 entries and it seems to work just fine. attached is: 
> povray.xml and it goes in the directory mentioned above.
>
> Attachments:
>  Download 'us-ascii' (23 KB)
Comment 1 Darrell 2012-10-19 21:53:48 CDT 
Nikolaus,

I was updating syntax highlighting files and going to push to GIT. I saw this request.

After comparing the attached file to the existing povray.xml file, I'm concerned about some things. One, the attached file is quite different. If you massage the existing and proposed files to look similar and then view them through kompare, you'll see the differences. The mimetypes in the attached version are not even the same.

Second, should any user choose to update their files in kate (Settings->Highlighting->Download), I suspect the downloaded copy will overwrite any existing copy.

I do not know how the kate code updates syntax highlighting files. I suspect the updating is based upon the internal version number in each xml file. We could edit the attached file to version 1.11, which would be a single minor revision number greater than the existing file (1.1), but if the upstream file is updated to version 1.2 then when a user downloads updates through kate the file will be overwritten.

I'm not sure of a good approach. :)
Comment 2 Nikolaus Klepp 2012-10-20 14:39:43 CDT 
I think you are right. I'll work over povray.xml and post a better version.
Comment 3 Darrell 2013-08-11 13:09:06 CDT 
Did anything ever happen with this report?
Comment 4 Slávek Banko 2014-01-09 18:29:18 CST 
In GIT commit bf4e405e was updated many syntax highlighting files for kate. Update was based on files from kate upstream. However file for PovRay remained essentially unchanged.

So, there is another question - we will update files to newer than the upstream? Or we will first endeavor to acceptance patch into kate upstream?
Comment 5 Darrell 2014-01-09 18:42:14 CST 
>we will update files to newer than the upstream? Or we will first endeavor to 
>acceptance patch into kate upstream?
We now use the upstream KDE changes only as a reference --- to 'diff' those changes back into our own files. We no longer use the upstream KDE files as masters. The Trinity master files are now those found in our own git tree.
Comment 6 Darrell 2014-01-09 18:44:19 CST 
>However file for PovRay remained essentially unchanged.
You are correct. :( We need to decide what will be our own master file and update accordingly. The original proposed changes were different from our original xml file. I don't know povray to know what changes we should make.
Comment 7 Nikolaus Klepp 2014-01-10 03:39:20 CST 
Sorry folks, real live got in my way, and in as time goes by I simply forgot about this. I hope I find some hour this weekend :-/
Comment 8 Darrell 2014-01-10 13:03:38 CST 
>in as time goes by I simply forgot about this.
We all did. :)

Please know that the new location for master updates is the Trinity git repo. By all means use the KDE file for a reference to update the Trinity version as necessary, but the KDE file is no longer the master. :)
Comment 9 Nikolaus Klepp 2014-01-16 08:04:34 CST 
Here it is ... it's just the original povray.xml from 3.5.13.2 with the additions for povray 3.7. I left the unofficial section untouched, as I do not use megapov.
Comment 10 Nikolaus Klepp 2014-01-16 08:05:33 CST 
Created attachment 1872 [details]
povray 3.7 languge definition for kate,extension of original povray.xml from tde 3.5.13.2
Comment 11 Darrell 2014-01-16 17:25:44 CST 
Nikolaus,

You seem to be our local povray expert. :) If you are content with this version of the povray.xml file then I'll push to git.

One note, I will update the following to match our latest git versions:

version="1.2" kateversion="2.5"
Comment 12 Slávek Banko 2014-01-18 19:53:56 CST 
With small modifications pushed to GIT in hash 50d58f6f.

To file version had newer than existing and at the same time make it clear that this is a adjustment derogate from the original kate version, I marked version 1.2.1.